New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Import knp features #45

Open

Nek- wants to merge 3 commits into master from import-knp-features

Nek- commented Mar 29, 2019 •

edited

Loading

This is some kind of rebase on KNPDictionary bundle. It imports new features.

I don't feel like we should take everything. Especially the refactoring of services definitions to YAML.

Here are some more integrations possible (vote please):

Refactor DictionaryRegistry to make it a Collection (huge breaking change) KnpLabs@14e903e KnpLabs@129878e 👍
Using 'use_strict' and type hinting anywhere (it's breaking change) ❤️
(more to come)

This fixes otherwise looks like a must have (and need to be implemented):

KnpLabs@464b53f

Thanks to KNP for their work.

Antoine Lelaisant added 3 commits

March 29, 2019 18:51


          Added CombinedDictionary

d55a10b


          Added documentation for ExtendedDictionary

7bf4267


          Added ExtendedDictionary

38e9b7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet